gilles/onvif-go
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: update HTTP request handling and improve documentation

Browse Source 
- Replaced http.NewRequest with http.NewRequestWithContext in client tests for better context management.
- Updated method names and comments for clarity, including renaming GetWsdlUrl to GetWsdlURL and StorageUri to StorageURI for consistency.
- Enhanced comments across various files to provide clearer descriptions of functionality and ONVIF specifications.
This commit is contained in:
0x524a
2025-12-02 08:41:37 -05:00
parent 9e3b5e0170
commit 96ac509c24
32 changed files with 248 additions and 184 deletions
Download Patch File Download Diff File Expand all files Collapse all files
device_storage_test.go
+6 -6
View File
@@ -147,8 +147,8 @@ func TestGetStorageConfigurations(t *testing.T) {
t.Errorf("Expected second config token 'storage-002', got '%s'", configs[1].Token)
}
if configs[1].Data.StorageUri != "cifs://nas.local/recordings" {
t.Errorf("Expected second config URI 'cifs://nas.local/recordings', got '%s'", configs[1].Data.StorageUri)
if configs[1].Data.StorageURI != "cifs://nas.local/recordings" {
t.Errorf("Expected second config URI 'cifs://nas.local/recordings', got '%s'", configs[1].Data.StorageURI)
}
}
@@ -175,8 +175,8 @@ func TestGetStorageConfiguration(t *testing.T) {
t.Errorf("Expected config path '/var/media/storage1', got '%s'", config.Data.LocalPath)
}
if config.Data.StorageUri != "file:///var/media/storage1" {
t.Errorf("Expected config URI 'file:///var/media/storage1', got '%s'", config.Data.StorageUri)
if config.Data.StorageURI != "file:///var/media/storage1" {
t.Errorf("Expected config URI 'file:///var/media/storage1', got '%s'", config.Data.StorageURI)
}
if config.Data.Type != "NFS" {
@@ -198,7 +198,7 @@ func TestCreateStorageConfiguration(t *testing.T) {
Token: "storage-new",
Data: StorageConfigurationData{
LocalPath: "/var/media/storage3",
StorageUri: "file:///var/media/storage3",
StorageURI: "file:///var/media/storage3",
Type: "Local",
},
}
@@ -227,7 +227,7 @@ func TestSetStorageConfiguration(t *testing.T) {
Token: "storage-001",
Data: StorageConfigurationData{
LocalPath: "/var/media/updated",
StorageUri: "file:///var/media/updated",
StorageURI: "file:///var/media/updated",
Type: "NFS",
},
}