WIP - start supporting NVME and SCSI drive smart data.

Added addiitonal log message data for Smartctl exit ccode.
2020-08-24 23:01:03 -07:00
parent 794479b28e
commit 5a80ae3e74
14 changed files with 2022 additions and 125 deletions
@@ -29,14 +29,127 @@ func TestFromCollectorSmartInfo(t *testing.T) {

 	//assert
 	require.NoError(t, err)
-	require.Equal(t, smartMdl.DeviceWWN, "WWN-test")
-	require.Equal(t, smartMdl.SmartStatus, "passed")
+	require.Equal(t, "WWN-test", smartMdl.DeviceWWN)
+	require.Equal(t, "passed", smartMdl.SmartStatus)
+	require.Equal(t, 18, len(smartMdl.AtaAttributes))
+	require.Equal(t, 0, len(smartMdl.NvmeAttributes))
+	require.Equal(t, 0, len(smartMdl.ScsiAttributes))

 	//check that temperature was correctly parsed
-	for _, attr := range smartMdl.SmartAttributes {
+	for _, attr := range smartMdl.AtaAttributes {
 		if attr.AttributeId == 194 {
 			require.Equal(t, int64(163210330144), attr.RawValue)
 			require.Equal(t, int64(32), attr.TransformedValue)
 		}
 	}
 }
+
+func TestFromCollectorSmartInfo_Fail(t *testing.T) {
+	//setup
+	smartDataFile, err := os.Open("../testdata/smart-fail.json")
+	require.NoError(t, err)
+	defer smartDataFile.Close()
+
+	var smartJson collector.SmartInfo
+
+	smartDataBytes, err := ioutil.ReadAll(smartDataFile)
+	require.NoError(t, err)
+	err = json.Unmarshal(smartDataBytes, &smartJson)
+	require.NoError(t, err)
+
+	//test
+	smartMdl := db.Smart{}
+	err = smartMdl.FromCollectorSmartInfo("WWN-test", smartJson)
+
+	//assert
+	require.NoError(t, err)
+	require.Equal(t, "WWN-test", smartMdl.DeviceWWN)
+	require.Equal(t, "failed", smartMdl.SmartStatus)
+	require.Equal(t, 0, len(smartMdl.AtaAttributes))
+	require.Equal(t, 0, len(smartMdl.NvmeAttributes))
+	require.Equal(t, 0, len(smartMdl.ScsiAttributes))
+}
+
+func TestFromCollectorSmartInfo_Fail2(t *testing.T) {
+	//setup
+	smartDataFile, err := os.Open("../testdata/smart-fail2.json")
+	require.NoError(t, err)
+	defer smartDataFile.Close()
+
+	var smartJson collector.SmartInfo
+
+	smartDataBytes, err := ioutil.ReadAll(smartDataFile)
+	require.NoError(t, err)
+	err = json.Unmarshal(smartDataBytes, &smartJson)
+	require.NoError(t, err)
+
+	//test
+	smartMdl := db.Smart{}
+	err = smartMdl.FromCollectorSmartInfo("WWN-test", smartJson)
+
+	//assert
+	require.NoError(t, err)
+	require.Equal(t, "WWN-test", smartMdl.DeviceWWN)
+	require.Equal(t, "failed", smartMdl.SmartStatus)
+	require.Equal(t, 17, len(smartMdl.AtaAttributes))
+	require.Equal(t, 0, len(smartMdl.NvmeAttributes))
+	require.Equal(t, 0, len(smartMdl.ScsiAttributes))
+}
+
+func TestFromCollectorSmartInfo_Nvme(t *testing.T) {
+	//setup
+	smartDataFile, err := os.Open("../testdata/smart-nvme.json")
+	require.NoError(t, err)
+	defer smartDataFile.Close()
+
+	var smartJson collector.SmartInfo
+
+	smartDataBytes, err := ioutil.ReadAll(smartDataFile)
+	require.NoError(t, err)
+	err = json.Unmarshal(smartDataBytes, &smartJson)
+	require.NoError(t, err)
+
+	//test
+	smartMdl := db.Smart{}
+	err = smartMdl.FromCollectorSmartInfo("WWN-test", smartJson)
+
+	//assert
+	require.NoError(t, err)
+	require.Equal(t, "WWN-test", smartMdl.DeviceWWN)
+	require.Equal(t, "passed", smartMdl.SmartStatus)
+	require.Equal(t, 0, len(smartMdl.AtaAttributes))
+	require.Equal(t, 16, len(smartMdl.NvmeAttributes))
+	require.Equal(t, 0, len(smartMdl.ScsiAttributes))
+
+	require.Equal(t, 111303174, smartMdl.NvmeAttributes[6].Value)
+	require.Equal(t, 83170961, smartMdl.NvmeAttributes[7].Value)
+}
+
+func TestFromCollectorSmartInfo_Scsi(t *testing.T) {
+	//setup
+	smartDataFile, err := os.Open("../testdata/smart-scsi.json")
+	require.NoError(t, err)
+	defer smartDataFile.Close()
+
+	var smartJson collector.SmartInfo
+
+	smartDataBytes, err := ioutil.ReadAll(smartDataFile)
+	require.NoError(t, err)
+	err = json.Unmarshal(smartDataBytes, &smartJson)
+	require.NoError(t, err)
+
+	//test
+	smartMdl := db.Smart{}
+	err = smartMdl.FromCollectorSmartInfo("WWN-test", smartJson)
+
+	//assert
+	require.NoError(t, err)
+	require.Equal(t, "WWN-test", smartMdl.DeviceWWN)
+	require.Equal(t, "passed", smartMdl.SmartStatus)
+	require.Equal(t, 0, len(smartMdl.AtaAttributes))
+	require.Equal(t, 0, len(smartMdl.NvmeAttributes))
+	require.Equal(t, 13, len(smartMdl.ScsiAttributes))
+
+	require.Equal(t, 56, smartMdl.ScsiAttributes[0].Value)
+	require.Equal(t, 300357663, smartMdl.ScsiAttributes[4].Value) //total_errors_corrected
+}