added ideal and thresholds for NVMe and SCSI drives.

Added functions (PopulateAttributeStatus) to ensure that NVME and SCSI drives set the status for SMART attributes.
Moved Status populating fucntion into the *Attribute files, so they are closer to the code they actually interact with.
Fix frontend to correctly display status, thresh and Ideal for NVMe and SCSI ddrives.

webapp/backend/pkg/models/db/smart_ata_attribute.go

@@ -3,6 +3,7 @@ package db
 import (
 	"github.com/analogj/scrutiny/webapp/backend/pkg/metadata"
 	"github.com/jinzhu/gorm"
+	"strings"
 )
 
 const SmartAttributeStatusPassed = "passed"
@@ -31,6 +32,28 @@ type SmartAtaAttribute struct {
 	History          []SmartAtaAttribute `gorm:"-" json:"history,omitempty"`
 }
 
+//populate attribute status, using SMART Thresholds & Observed Metadata
+func (sa *SmartAtaAttribute) PopulateAttributeStatus() {
+	if strings.ToUpper(sa.WhenFailed) == SmartWhenFailedFailingNow {
+		//this attribute has previously failed
+		sa.Status = SmartAttributeStatusFailed
+		sa.StatusReason = "Attribute is failing manufacturer SMART threshold"
+
+	} else if strings.ToUpper(sa.WhenFailed) == SmartWhenFailedInThePast {
+		sa.Status = SmartAttributeStatusWarning
+		sa.StatusReason = "Attribute has previously failed manufacturer SMART threshold"
+	}
+
+	if smartMetadata, ok := metadata.AtaMetadata[sa.AttributeId]; ok {
+		sa.MetadataObservedThresholdStatus(smartMetadata)
+	}
+
+	//check if status is blank, set to "passed"
+	if len(sa.Status) == 0 {
+		sa.Status = SmartAttributeStatusPassed
+	}
+}
+
 // compare the attribute (raw, normalized, transformed) value to observed thresholds, and update status if necessary
 func (sa *SmartAtaAttribute) MetadataObservedThresholdStatus(smartMetadata metadata.AtaAttributeMetadata) {
 	//TODO: multiple rules