Maia comments: change MAX_ALPHA to 0.5, add slope calculation at each cycle.

custom_components/versatile_thermostat/base_thermostat.py

@@ -113,7 +113,7 @@ from .underlyings import UnderlyingEntity
 
 from .prop_algorithm import PropAlgorithm
 from .open_window_algorithm import WindowOpenDetectionAlgorithm
-from .ema import EstimatedMobileAverage
+from .ema import ExponentialMovingAverage
 
 _LOGGER = logging.getLogger(__name__)
 
@@ -253,7 +253,7 @@ class BaseThermostat(ClimateEntity, RestoreEntity):
 
         self._underlyings = []
 
-        self._smooth_temp = None
+        self._ema_temp = None
         self._ema_algo = None
         self.post_init(entry_infos)
 
@@ -459,11 +459,13 @@ class BaseThermostat(ClimateEntity, RestoreEntity):
 
         self._total_energy = 0
 
-        self._ema_algo = EstimatedMobileAverage(
+        self._ema_algo = ExponentialMovingAverage(
             self.name,
             self._cycle_min * 60,
             # Needed for time calculation
             get_tz(self._hass),
+            # two digits after the coma for temperature slope calculation
+            2,
         )
 
         _LOGGER.debug(
@@ -2093,6 +2095,9 @@ class BaseThermostat(ClimateEntity, RestoreEntity):
                 force,
             )
 
+        # calculate the smooth_temperature with EMA calculation
+        await self._async_manage_window_auto()
+
         self.update_custom_attributes()
         return True
 

custom_components/versatile_thermostat/ema.py

@@ -8,25 +8,28 @@ from datetime import datetime, tzinfo
 
 _LOGGER = logging.getLogger(__name__)
 
-MIN_TIME_DECAY_SEC = 5
+MIN_TIME_DECAY_SEC = 0
 # As for the EMA calculation of irregular time series, I've seen that it might be useful to
 # have an upper limit for alpha in case the last measurement was too long ago.
 # For example when using a half life of 10 minutes a measurement that is 60 minutes ago
 # (if there's nothing inbetween) would contribute to the smoothed value with 1,5%,
 # giving the current measurement 98,5% relevance. It could be wise to limit the alpha to e.g. 4x the half life (=0.9375).
-MAX_ALPHA = 0.9375
+MAX_ALPHA = 0.5
 
 
-class EstimatedMobileAverage:
+class ExponentialMovingAverage:
     """A class that will do the Estimated Mobile Average calculation"""
 
-    def __init__(self, vterm_name: str, halflife: float, timezone: tzinfo):
+    def __init__(
+        self, vterm_name: str, halflife: float, timezone: tzinfo, precision: int = 3
+    ):
         """The halflife is the duration in secondes of a normal cycle"""
         self._halflife: float = halflife
         self._timezone = timezone
         self._current_ema: float = None
         self._last_timestamp: datetime = datetime.now(self._timezone)
         self._name = vterm_name
+        self._precision = precision
 
     def __str__(self) -> str:
         return f"EMA-{self._name}"
@@ -64,17 +67,19 @@ class EstimatedMobileAverage:
 
         alpha = 1 - math.exp(math.log(0.5) * time_decay / self._halflife)
         # capping alpha to avoid gap if last measurement was long time ago
-        alpha = min(alpha, 0.9375)
-        new_ema = round(alpha * measurement + (1 - alpha) * self._current_ema, 1)
+        alpha = min(alpha, MAX_ALPHA)
+        new_ema = alpha * measurement + (1 - alpha) * self._current_ema
 
         self._last_timestamp = timestamp
         self._current_ema = new_ema
         _LOGGER.debug(
-            "%s - alpha=%.2f new_ema=%.2f last_timestamp=%s",
+            "%s - timestamp=%s alpha=%.2f measurement=%.2f current_ema=%.2f new_ema=%.2f",
             self,
+            timestamp,
             alpha,
+            measurement,
             self._current_ema,
-            self._last_timestamp,
+            new_ema,
         )
 
-        return self._current_ema
+        return round(self._current_ema, self._precision)

custom_components/versatile_thermostat/open_window_algorithm.py

@@ -1,3 +1,4 @@
+# pylint: disable=line-too-long
 """ This file implements the Open Window by temperature algorithm
     This algo works the following way:
     - each time a new temperature is measured
@@ -12,7 +13,7 @@ from datetime import datetime
 _LOGGER = logging.getLogger(__name__)
 
 # To filter bad values
-MIN_DELTA_T_SEC = 30  # two temp mesure should be > 10 sec
+MIN_DELTA_T_SEC = 15  # two temp mesure should be > 10 sec
 MAX_SLOPE_VALUE = 2  # slope cannot be > 2 or < -2 -> else this is an aberrant point
 
 
@@ -71,10 +72,10 @@ class WindowOpenDetectionAlgorithm:
             )
             return lspe
 
-        if self._last_slope is None:
-            self._last_slope = new_slope
-        else:
-            self._last_slope = (0.5 * self._last_slope) + (0.5 * new_slope)
+        # if self._last_slope is None:
+        self._last_slope = round(new_slope, 4)
+        # else:
+        #    self._last_slope = (0.5 * self._last_slope) + (0.5 * new_slope)
 
         self._last_datetime = datetime_measure
         self._last_temperature = temperature

tests/test_ema.py

@@ -4,7 +4,7 @@ from datetime import datetime, timedelta
 
 from homeassistant.core import HomeAssistant
 
-from custom_components.versatile_thermostat.ema import EstimatedMobileAverage
+from custom_components.versatile_thermostat.ema import ExponentialMovingAverage
 
 from .commons import get_tz
 
@@ -15,12 +15,13 @@ def test_ema_basics(hass: HomeAssistant):
     tz = get_tz(hass)  # pylint: disable=invalid-name
     now: datetime = datetime.now(tz=tz)
 
-    the_ema = EstimatedMobileAverage(
+    the_ema = ExponentialMovingAverage(
         "test",
         # 5 minutes
         300,
         # Needed for time calculation
         get_tz(hass),
+        1,
     )
 
     assert the_ema

tests/test_multiple_switch.py

@@ -386,6 +386,7 @@ async def test_multiple_climates(
             CONF_THERMOSTAT_TYPE: CONF_THERMOSTAT_CLIMATE,
             CONF_TEMP_SENSOR: "sensor.mock_temp_sensor",
             CONF_EXTERNAL_TEMP_SENSOR: "sensor.mock_ext_temp_sensor",
+            CONF_CYCLE_MIN: 8,
             CONF_TEMP_MIN: 15,
             CONF_TEMP_MAX: 30,
             "eco_temp": 17,
@@ -486,6 +487,7 @@ async def test_multiple_climates_underlying_changes(
             CONF_THERMOSTAT_TYPE: CONF_THERMOSTAT_CLIMATE,
             CONF_TEMP_SENSOR: "sensor.mock_temp_sensor",
             CONF_EXTERNAL_TEMP_SENSOR: "sensor.mock_ext_temp_sensor",
+            CONF_CYCLE_MIN: 8,
             CONF_TEMP_MIN: 15,
             CONF_TEMP_MAX: 30,
             "eco_temp": 17,