Issue #295 - No floating point value for target temp

README-fr.md

@@ -114,7 +114,7 @@ En conséquence toute la phase de paramètrage d'un VTherm a été profondemment
 **Note :** les copies d'écran de la configuration d'un VTherm n'ont pas été mises à jour.
 
 # Merci pour la bière [buymecoffee](https://www.buymeacoffee.com/jmcollin78)
-Un grand merci à @salabur, @pvince83, @bergoglio, @EPicLURcher, @ecolorado66, @Kriss1670, @maia, @f.maymil, @moutte69, @Jerome, @Gunnar M, @Greg.o, @John Burgess, @abyssmal, @capinfo26, @Helge, @MattG @Mexx62, @Someone pour les bières. Ca fait très plaisir et ça m'encourage à continuer !
+Un grand merci à @salabur, @pvince83, @bergoglio, @EPicLURcher, @ecolorado66, @Kriss1670, @maia, @f.maymil, @moutte69, @Jerome, @Gunnar M, @Greg.o, @John Burgess, @abyssmal, @capinfo26, @Helge, @MattG @Mexx62, @Someone, @Lajull pour les bières. Ca fait très plaisir et ça m'encourage à continuer !
 
 
 # Quand l'utiliser et ne pas l'utiliser

README.md

@@ -114,7 +114,7 @@ Consequently, the entire configuration phase of a VTherm has been profoundly mod
 **Note:** the VTherm configuration screenshots have not been updated.
 
 # Thanks for the beer [buymecoffee](https://www.buymeacoffee.com/jmcollin78)
-Many thanks to @salabur, @pvince83, @bergoglio, @EPicLURcher, @ecolorado66, @Kriss1670, @maia, @f.maymil, @moutte69, @Jerome, @Gunnar M, @Greg.o, @John Burgess, @abyssmal, @capinfo26, @Helge, @MattG, @MattG, @Mexx62, @Someone for the beers. It's very nice and encourages me to continue!
+Many thanks to @salabur, @pvince83, @bergoglio, @EPicLURcher, @ecolorado66, @Kriss1670, @maia, @f.maymil, @moutte69, @Jerome, @Gunnar M, @Greg.o, @John Burgess, @abyssmal, @capinfo26, @Helge, @MattG, @MattG, @Mexx62, @Someone, @Lajull for the beers. It's very nice and encourages me to continue!
 
 # When to use / not use
 This thermostat can control 3 types of equipment:

custom_components/versatile_thermostat/config_flow.py

@@ -364,7 +364,7 @@ class VersatileThermostatBaseConfigFlow(FlowHandler):
             schema = schema_ac_or_not
         elif user_input and user_input.get(CONF_USE_PRESETS_CENTRAL_CONFIG) is False:
             next_step = self.async_step_spec_presets
-            schema = schema_ac_or_not
+            schema = STEP_PRESETS_DATA_SCHEMA
 
         return await self.generic_step("presets", schema, user_input, next_step)
 

custom_components/versatile_thermostat/thermostat_climate.py

@@ -136,6 +136,11 @@ class ThermostatOverClimate(BaseThermostat):
 
     async def _send_regulated_temperature(self, force=False):
         """Sends the regulated temperature to all underlying"""
+
+        if self.hvac_mode == HVACMode.OFF:
+            _LOGGER.debug("%s - don't send regulated temperature cause VTherm is off ")
+            return
+
         _LOGGER.info(
             "%s - Calling ThermostatClimate._send_regulated_temperature force=%s",
             self,

custom_components/versatile_thermostat/underlyings.py

@@ -690,7 +690,7 @@ class UnderlyingClimate(UnderlyingEntity):
             min_val = self._underlying_climate.min_temp
             max_val = self._underlying_climate.max_temp
 
-            new_value = round(max(min_val, min(value, max_val)))
+            new_value = max(min_val, min(value, max_val))
         else:
             _LOGGER.debug("%s - no min and max attributes on underlying", self)
             new_value = value

tests/test_bugs.py

@@ -629,19 +629,24 @@ async def test_bug_272(
         assert mock_service_call.call_count == 0
 
         # Set the hvac_mode to HEAT
-        entity.async_set_hvac_mode(HVACMode.HEAT)
+        await entity.async_set_hvac_mode(HVACMode.HEAT)
 
         # In the accepted interval
-        await entity.async_set_temperature(temperature=17)
-        assert mock_service_call.call_count == 1
+        await entity.async_set_temperature(temperature=17.5)
+        assert mock_service_call.call_count == 2
         mock_service_call.assert_has_calls(
             [
+                call.async_call(
+                    "climate",
+                    SERVICE_SET_HVAC_MODE,
+                    {"entity_id": "climate.mock_climate", "hvac_mode": HVACMode.HEAT},
+                ),
                 call.async_call(
                     "climate",
                     SERVICE_SET_TEMPERATURE,
                     {
                         "entity_id": "climate.mock_climate",
-                        "temperature": 17,
+                        "temperature": 17.5,
                         "target_temp_high": 30,
                         "target_temp_low": 15,
                     },
@@ -661,7 +666,7 @@ async def test_bug_272(
         await send_temperature_change_event(entity, 13, event_timestamp)
         await send_ext_temperature_change_event(entity, 9, event_timestamp)
 
-        # In the accepted interval
+        # Not in the accepted interval (15-19)
         await entity.async_set_temperature(temperature=10)
         assert mock_service_call.call_count == 1
         mock_service_call.assert_has_calls(
@@ -689,7 +694,7 @@ async def test_bug_272(
         await send_ext_temperature_change_event(entity, 9, event_timestamp)
 
         # In the accepted interval
-        await entity.async_set_temperature(temperature=20)
+        await entity.async_set_temperature(temperature=20.8)
         assert mock_service_call.call_count == 1
         mock_service_call.assert_has_calls(
             [